src/Consolonia.Core/InternalHelpers/CommonInternalHelper.cs (1)

Line range hint 8-11: Fix IsNearlyEqual implementation

The current implementation using CompareTo doesn't handle floating-point comparison correctly. The TODO comment also indicates this is problematic.

Consider this implementation instead:

-public static bool IsNearlyEqual(this double value, double compareTo)
-{
-    //todo: strange implementation for this name
-    return value.CompareTo(compareTo) == 0;
-}
+public static bool IsNearlyEqual(this double value, double compareTo, double epsilon = 1e-10)
+{
+    return Math.Abs(value - compareTo) < epsilon;
+}

src/Consolonia.Themes/Templates/Controls/SelectableTextBlock.axaml (1)

8-9: Consider UX implications of right-click selection

Using right-click for text selection (SelectOnMouseRightUp="True") is an unconventional choice that might confuse users, as right-click typically opens context menus. Consider:

1. Using left-click for selection (standard behavior)
2. Adding a context menu for additional actions

Would you like assistance in implementing a more conventional selection behavior?

src/Consolonia.Core/InternalHelpers/CommonInternalHelper.cs (2)

6-6: Reconsider making CommonInternalHelper public

Changing the class from internal to public exposes implementation details that were previously encapsulated. This could make future maintenance more difficult as other assemblies might start depending on these utilities.

Consider:

1. Creating a separate public API if these utilities are needed externally
2. Keeping implementation details internal to maintain encapsulation

---

Line range hint 18-23: Modernize null checking

The NotNull method could be simplified using C# 8.0's null-coalescing operator.

Consider this more concise implementation:

-public static T NotNull<T>(this T? t) where T : struct
-{
-    if (t == null)
-        throw new ConsoloniaException("Value is not expected to be null");
-    return t.Value;
-}
+public static T NotNull<T>(this T? t) where T : struct
+    => t ?? throw new ConsoloniaException("Value is not expected to be null");

src/Consolonia.Core/Infrastructure/IConsole.cs (1)

25-26: Add XML documentation for mouse support properties

Similar to SupportsComplexEmoji, these new properties should have XML documentation explaining their purpose and implications.

Add documentation like this:

+/// <summary>
+///     Indicates whether this console implementation supports mouse input.
+/// </summary>
 bool SupportsMouse { get; }

+/// <summary>
+///     Indicates whether this console implementation supports mouse movement tracking.
+/// </summary>
 bool SupportsMouseMove { get; }

src/Consolonia.Gallery/Gallery/GalleryViews/GalleryTextBlock.axaml (1)

23-25: Consider improving the SelectableTextBlock demonstration

The current implementation has a few potential issues:

1. The pre-defined selection range (17-26) might be confusing as it's not immediately clear what text is being selected
2. The demonstration could be more effective with clearer examples

Consider these improvements:

-        <SelectableTextBlock  SelectionStart="17" SelectionEnd="26">
-            Selectable text: Loreum ipsum dolor sit amet, consectetur adipiscing elit. Vivamus magna. Cras in mi at felis aliquet congue. Ut a est eget ligula molestie gravida. Curabitur massa. Donec eleifend, libero at sagittis
+        <SelectableTextBlock>
+            Try selecting this text with your mouse! This demonstrates the text selection functionality.
+        </SelectableTextBlock>
+        <!-- Example with pre-selected text -->
+        <SelectableTextBlock SelectionStart="0" SelectionEnd="15">
+            Selected text: This text starts pre-selected to demonstrate the selection API.
+        </SelectableTextBlock>

src/Consolonia.NUnit/UnitTestConsole.cs (1)

Line range hint 193-193: Consider documenting the unused MouseEvent

The MouseEvent is defined but never raised since mouse support is disabled. Consider adding a comment explaining this design decision.

+        // MouseEvent is defined for interface compatibility but never raised as mouse support is disabled
         public event Action<RawPointerEventType, Point, Vector?, RawInputModifiers> MouseEvent;

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

#!/bin/bash
# Search for ThemeActionBackgroundBrush definition
rg -l "ThemeActionBackgroundBrush" --type xaml

#!/bin/bash
# Search for ThemeActionBackgroundBrush definition in all files
# Using ripgrep without file type filter since .xaml extension isn't recognized
rg -l "ThemeActionBackgroundBrush"

#!/bin/bash
# Find all .xaml files in the repository to understand resource structure
fd -e xaml

#!/bin/bash
# Look for resource dictionaries that might contain brush definitions
rg -l "ResourceDictionary|<Style|<Brush" 

#!/bin/bash
# Check the definition of ThemeActionBackgroundBrush in color resource files
rg "ThemeActionBackgroundBrush" src/Consolonia.Themes/Templates/TurboVisionDefaultColors.axaml -A 2 -B 2

#!/bin/bash
# Check if the SelectableTextBlock template merges the required resource dictionaries
rg "MergedDictionaries|Source=" src/Consolonia.Themes/Templates/Controls/SelectableTextBlock.axaml -A 2 -B 2

#!/bin/bash
# Search for MouseEvent implementations
ast-grep --pattern 'class $_ : IConsole {
  $$$
  event Action<RawPointerEventType, Point, Vector?, RawInputModifiers> MouseEvent
  $$$
}'

#!/bin/bash
# Search for files containing IConsole implementations
fd -e cs | xargs rg -l "class.*:.*IConsole"

# Search for files containing MouseEvent
fd -e cs | xargs rg "MouseEvent"

# Search for SupportsMouse and SupportsMouseMove implementations
fd -e cs | xargs rg "(SupportsMouse|SupportsMouseMove)"

#!/bin/bash
# Description: Check if mouse move events are actually used in the codebase

# Search for mouse move event handling
rg -l "RawPointerEventType.Move" --type cs

# Search for specific usage of ReportMousePosition
ast-grep --pattern 'ReportMousePosition'

#!/bin/bash
# Check the implementation details of mouse move handling
rg "RawPointerEventType.Move" -B 5 -A 5 --type cs

# Check MouseEventFlagTranslator implementation
rg "MouseEventFlagTranslator" -B 5 -A 15 --type cs

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

Learnt from: jinek
PR: jinek/Consolonia#219
File: src/Consolonia.Themes/Templates/Controls/Helpers/SelectTextWithPointerUpExtension.cs:21-25
Timestamp: 2024-12-19T21:20:43.248Z
Learning: When mouseMove is supported by IConsole, the SelectableTextBlock handles selection normally without needing an additional subscription for right-click pointer up events in SelectTextWithPointerUpExtension.